]> xenbits.xen.org Git - xenclient/kernel.git/commit
commit 432409eebcdec38ff6fa949f097b5438d588faa5 bnx2i-host-params
authort_jeang <devnull@localhost>
Tue, 6 Jan 2009 12:06:00 +0000 (12:06 +0000)
committert_jeang <devnull@localhost>
Tue, 6 Jan 2009 12:06:00 +0000 (12:06 +0000)
commit79db6804be23f16d48c9cec558f81549a47b3174
tree3e69ddbf731c06a48cd0a07d519caf343aae2793
parenta19d8a1140d01b079f65b8ecb036bb0528686116
commit 432409eebcdec38ff6fa949f097b5438d588faa5
Author: Neil Brown <neilb@suse.de>
Date:   Tue Oct 23 17:09:13 2007 -0400

    NFS: Fix for bug in handling of errors for O_DIRECT writes

    Commit eda3cef8dd2b83875affe82595db9d0c278879b2 ("NFS: Fix error
    handling in nfs_direct_write_result()") ensured that if a WRITE returns
    an error, then data->res.verf->committed is not tested (as it is not
    initialised).

    Then commit 60fa3f769f7651a60125a0f44e3ffe3246d7cf39 ("NFS: Fix two bugs
    in the O_DIRECT write code") inadvertently reverted this while fixing
    other problems.

    So move the test so that we never examine ->committed in an error case,
    and fix a speeling error while we are there.

Cc: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Neil Brown <neilb@suse.de>
Acked-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nfs/direct.c