# HG changeset patch # User Keir Fraser # Date 1264749028 0 # Node ID 8dcedf17b5b4ffbbd50c19dabd3b221f6d58be89 # Parent ebd2495ec073064d5f05754060fdf6ce38b907a3 pv-on-hvm: Correct the order of the argument of out*() The order of the argument of outl() is wrong. The correct order is outl(value, port). This causes kernel panic. And outw() is also similar. Signed-off-by: KUWAMURA Shin'ya diff -r ebd2495ec073 -r 8dcedf17b5b4 unmodified_drivers/linux-2.6/platform-pci/platform-pci.c --- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c Fri Jan 29 06:50:23 2010 +0000 +++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c Fri Jan 29 07:10:28 2010 +0000 @@ -324,15 +324,15 @@ static int check_platform_magic(struct d switch (protocol) { case 1: - outw(XEN_IOPORT_PRODNUM, XEN_IOPORT_LINUX_PRODNUM); - outl(XEN_IOPORT_DRVVER, XEN_IOPORT_LINUX_DRVVER); + outw(XEN_IOPORT_LINUX_PRODNUM, XEN_IOPORT_PRODNUM); + outl(XEN_IOPORT_LINUX_DRVVER, XEN_IOPORT_DRVVER); if (inw(XEN_IOPORT_MAGIC) != XEN_IOPORT_MAGIC_VAL) { dev_err(dev, "blacklisted by host\n"); return -ENODEV; } /* Fall through */ case 0: - outw(XEN_IOPORT_UNPLUG, 0xf); + outw(0xf, XEN_IOPORT_UNPLUG); break; default: err = "unknown I/O protocol version";