debuggers.hg
changeset 22740:9b5d121c8805
x86_64: don't use weak symbols on x86-64
Various gcc versions inline functions that are both weak and hidden,
without even giving a warning.
Certainly the risk exists that we'll see the problem again when
another weak function gets introduced, but I don't see a way to
protect us from that.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Just remove the weak attribute altogether. It's the only one in
non-ia64-specific code. We can get teh same effect with ifdefs which
although a bit unsightly is better than using compiler/linker features
we cannot trust.
Signed-off-by: Keir Fraser <keir@xen.org>
Various gcc versions inline functions that are both weak and hidden,
without even giving a warning.
Certainly the risk exists that we'll see the problem again when
another weak function gets introduced, but I don't see a way to
protect us from that.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Just remove the weak attribute altogether. It's the only one in
non-ia64-specific code. We can get teh same effect with ifdefs which
although a bit unsightly is better than using compiler/linker features
we cannot trust.
Signed-off-by: Keir Fraser <keir@xen.org>
author | Keir Fraser <keir@xen.org> |
---|---|
date | Mon Jan 10 08:45:19 2011 +0000 (2011-01-10) |
parents | 08bb0eefe871 |
children | 55450858f414 |
files | xen/drivers/acpi/numa.c |
line diff
1.1 --- a/xen/drivers/acpi/numa.c Mon Jan 10 08:42:32 2011 +0000 1.2 +++ b/xen/drivers/acpi/numa.c Mon Jan 10 08:45:19 2011 +0000 1.3 @@ -120,14 +120,15 @@ static int __init acpi_parse_slit(struct 1.4 return 0; 1.5 } 1.6 1.7 -void __init __attribute__ ((weak)) 1.8 +#ifndef CONFIG_X86 1.9 +void __init 1.10 acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa) 1.11 { 1.12 printk(KERN_WARNING PREFIX 1.13 "Found unsupported x2apic [0x%08x] SRAT entry\n", pa->apic_id); 1.14 return; 1.15 } 1.16 - 1.17 +#endif 1.18 1.19 static int __init 1.20 acpi_parse_x2apic_affinity(struct acpi_subtable_header *header,