debuggers.hg

changeset 22884:aab67c1c6b87

find changesets by author, revision, files, or words in the commit message
xl: remove unimplemented -l stub for cpupool-list

Although advertised via the usage output, xl cpupool-list -l just
returns ERROR_NI, which does not show up on the console. Instead the
output is empty, which is not exactly what --long hints to. To avoid
confusion remove the line from the help output and just ignore the -l
option properly until it gets finally implemented.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
author Andre Przywara <andre.przywara@amd.com>
date Fri Jan 28 17:43:50 2011 +0000 (2011-01-28)
parents b58c9dd4ba90
children 6d6465868420
files tools/libxl/xl_cmdimpl.c tools/libxl/xl_cmdtable.c
line diff
     1.1 --- a/tools/libxl/xl_cmdimpl.c	Fri Jan 28 17:41:15 2011 +0000
     1.2 +++ b/tools/libxl/xl_cmdimpl.c	Fri Jan 28 17:43:50 2011 +0000
     1.3 @@ -5439,13 +5439,11 @@ int main_cpupoollist(int argc, char **ar
     1.4          return -ERROR_NOMEM;
     1.5      }
     1.6  
     1.7 -    if (!opt_long) {
     1.8 -        printf("%-19s", "Name");
     1.9 -        if (opt_cpus)
    1.10 -            printf("CPU list\n");
    1.11 -        else
    1.12 -            printf("CPUs   Sched     Active   Domain count\n");
    1.13 -    }
    1.14 +    printf("%-19s", "Name");
    1.15 +    if (opt_cpus)
    1.16 +        printf("CPU list\n");
    1.17 +    else
    1.18 +        printf("CPUs   Sched     Active   Domain count\n");
    1.19  
    1.20      for (p = 0; p < n_pools; p++) {
    1.21          if (!ret && (!pool || (poolinfo[p].poolid != poolid))) {
    1.22 @@ -5453,9 +5451,6 @@ int main_cpupoollist(int argc, char **ar
    1.23              if (!name) {
    1.24                  fprintf(stderr, "error getting cpupool info\n");
    1.25                  ret = -ERROR_NOMEM;
    1.26 -            }
    1.27 -            else if (opt_long) {
    1.28 -                ret = -ERROR_NI;
    1.29              } else {
    1.30                  printf("%-19s", name);
    1.31                  free(name);

     2.1 --- a/tools/libxl/xl_cmdtable.c	Fri Jan 28 17:41:15 2011 +0000
     2.2 +++ b/tools/libxl/xl_cmdtable.c	Fri Jan 28 17:43:50 2011 +0000
     2.3 @@ -349,8 +349,7 @@ struct cmd_spec cmd_table[] = {
     2.4      { "cpupool-list",
     2.5        &main_cpupoollist,
     2.6        "List CPU pools on host",
     2.7 -      "[-l|--long] [-c|--cpus] [<CPU Pool>]",
     2.8 -      "-l, --long                     Output all CPU pool details.\n"
     2.9 +      "[-c|--cpus] [<CPU Pool>]",
    2.10        "-c, --cpus                     Output list of CPUs used by a pool"
    2.11      },
    2.12      { "cpupool-destroy",