debuggers.hg

changeset 21065:bfaafdddf31a

tmem: typo causes incorrect return on out-of-memory

This classic typo in tmem would result in a false positive
report on a tmem "put" operation if a (unfragmented) page
of memory is completely unavailable.

Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
author Keir Fraser <keir.fraser@citrix.com>
date Tue Mar 09 17:53:01 2010 +0000 (2010-03-09)
parents 5f08fd0d6249
children 3198a2e81d38
files xen/common/tmem.c
line diff
     1.1 --- a/xen/common/tmem.c	Tue Mar 09 12:34:39 2010 +0000
     1.2 +++ b/xen/common/tmem.c	Tue Mar 09 17:53:01 2010 +0000
     1.3 @@ -1308,7 +1308,7 @@ static NOINLINE int do_tmem_put(pool_t *
     1.4  copy_uncompressed:
     1.5      if ( ( pgp->pfp = tmem_page_alloc(pool) ) == NULL )
     1.6      {
     1.7 -        ret == -ENOMEM;
     1.8 +        ret = -ENOMEM;
     1.9          goto delete_and_free;
    1.10      }
    1.11      /* tmh_copy_from_client properly handles len==0 (TMEM_NEW_PAGE) */