debuggers.hg

changeset 20886:c06732ac2392

x86: kill msix_flush_writes()

The (only) two callers of it don't need it, as the MSI-X case of
msi_set_mask_bit() already does the necessary readl().

Signed-off-by: Jan Beulich <jbeulich@novell.com>
author Keir Fraser <keir.fraser@citrix.com>
date Thu Jan 21 15:13:00 2010 +0000 (2010-01-21)
parents 57893d13574c
children fbe8f32fa257
files xen/arch/x86/msi.c
line diff
     1.1 --- a/xen/arch/x86/msi.c	Thu Jan 21 15:12:38 2010 +0000
     1.2 +++ b/xen/arch/x86/msi.c	Thu Jan 21 15:13:00 2010 +0000
     1.3 @@ -327,27 +327,6 @@ static void msix_set_enable(struct pci_d
     1.4      }
     1.5  }
     1.6  
     1.7 -static void msix_flush_writes(unsigned int irq)
     1.8 -{
     1.9 -    struct msi_desc *entry = irq_desc[irq].msi_desc;
    1.10 -
    1.11 -    BUG_ON(!entry || !entry->dev);
    1.12 -    switch (entry->msi_attrib.type) {
    1.13 -    case PCI_CAP_ID_MSI:
    1.14 -        /* nothing to do */
    1.15 -        break;
    1.16 -    case PCI_CAP_ID_MSIX:
    1.17 -    {
    1.18 -        int offset = PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET;
    1.19 -        readl(entry->mask_base + offset);
    1.20 -        break;
    1.21 -    }
    1.22 -    default:
    1.23 -        BUG();
    1.24 -        break;
    1.25 -    }
    1.26 -}
    1.27 -
    1.28  int msi_maskable_irq(const struct msi_desc *entry)
    1.29  {
    1.30      BUG_ON(!entry);
    1.31 @@ -409,13 +388,11 @@ static int msi_get_mask_bit(const struct
    1.32  void mask_msi_irq(unsigned int irq)
    1.33  {
    1.34      msi_set_mask_bit(irq, 1);
    1.35 -    msix_flush_writes(irq);
    1.36  }
    1.37  
    1.38  void unmask_msi_irq(unsigned int irq)
    1.39  {
    1.40      msi_set_mask_bit(irq, 0);
    1.41 -    msix_flush_writes(irq);
    1.42  }
    1.43  
    1.44  static struct msi_desc* alloc_msi_entry(void)