debuggers.hg

changeset 21033:c4301c2c727d

Revert 20954:b4041e7bbe1b "paging_domctl: Add missing breaks in switch stmt"

This fixed a fairly innocuous bug (OP_ENABLE/OP_OFF both don't work
properly) but unmasked a much nastier one (turning off shadow mode on
a PV guest crashes the hypervisor).

So, for now, we pick the less of two evils. We don't really much rely
on OP_ENABLE/OP_OFF anyway, as it happens.

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
author Keir Fraser <keir.fraser@citrix.com>
date Fri Feb 26 17:09:50 2010 +0000 (2010-02-26)
parents 6aa9fb913044
children e9146e92df62
files xen/arch/x86/mm/paging.c
line diff
     1.1 --- a/xen/arch/x86/mm/paging.c	Fri Feb 26 14:06:16 2010 +0000
     1.2 +++ b/xen/arch/x86/mm/paging.c	Fri Feb 26 17:09:50 2010 +0000
     1.3 @@ -714,13 +714,11 @@ int paging_domctl(struct domain *d, xen_
     1.4                  hap_logdirty_init(d);
     1.5              return paging_log_dirty_enable(d);
     1.6          }
     1.7 -        break;
     1.8  
     1.9      case XEN_DOMCTL_SHADOW_OP_OFF:
    1.10          if ( paging_mode_log_dirty(d) )
    1.11              if ( (rc = paging_log_dirty_disable(d)) != 0 )
    1.12                  return rc;
    1.13 -        break;
    1.14  
    1.15      case XEN_DOMCTL_SHADOW_OP_CLEAN:
    1.16      case XEN_DOMCTL_SHADOW_OP_PEEK: